-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display timestamp, useful to find timing problem #680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this show the log level and line? Also, what is the format when not using embassy and the selected feature for timestamps?
Yes, it shows the log level and line too. Using same display code from defmt.
Display rest of info without timestamp. |
Yes, here is an image of defmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind resolving the conflicts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've resolved the conflict, changes seem fine to me. @SergioGasquez will give you final say on this and let you merge it if you approve :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! And thanks for resolving the conflict @jessebraham!
I found timestamp in defmt documents, but following their instruction still don't show timestamp.
Spent a week figured out it's because espflash didn't display it.
This change made following work too
in Cargo.toml dependency:
embassy-time ={ version = "0.3.1" , features = ["defmt-timestamp-uptime"] }